#3 image-buttons

submitted on by Manuel

Bad code

<img src="/images/edit.gif" onclick="openEditDialog(123)">
<img src="/images/delete.gif" onclick="openDeleteDialog(123)">

Issues and how to fix them

  1. The purpose of the img element is to display images, not to execute JavaScript.
  2. A click event on a img triggers only on click. A click event on a button triggers on click and if the user presses the Enter or Space key.
  3. There’s no text alternative for the image. Screen readers may announce the filename instead.

Good code

Solution #1: Use buttons and add alt attribute to images

<button onclick="openEditDialog(123)">
<img src="/images/edit.gif" alt="Edit product XY">
<button onclick="openDeleteDialog(123)">
<img src="/images/delete.gif" alt="Delete product XY">

Solution #2: Use buttons, add text content and hide images

Unfortunately, there’s no native way of hiding content only visually.
The .sr-only class makes sure that content is visually hidden but still accessible to screen reader users.

.sr-only {
position: absolute;
white-space: nowrap;
width: 1px;
height: 1px;
overflow: hidden;
border: 0;
padding: 0;
clip: rect(0 0 0 0);
clip-path: inset(50%);
margin: -1px;

An image with an empty alt attribute is not accessible to screen reader users, which in this case is desired, because there’s a screen reader accessible text alternative.

<button onclick="openEditDialog(123)">
<span class="sr-only">Edit product XY</span>
<img src="/images/edit.gif" alt="">
<button onclick="openDeleteDialog(123)">
<span class="sr-only">Delete product XY</span>
<img src="/images/delete.gif" alt="">